Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nnn leaves zombies while running plugins #999

Closed
GeorgMeore opened this issue May 12, 2021 · 7 comments · Fixed by #1000
Closed

nnn leaves zombies while running plugins #999

GeorgMeore opened this issue May 12, 2021 · 7 comments · Fixed by #1000
Labels

Comments

@GeorgMeore
Copy link

I noticed that each time i run plugin in nnn it creates zombie nnn child processes.
It happens both with plugins which run in background, such as

#!/bin/sh
nohup zathura "$1" >/dev/null 2>&1 &

and foreground plugins, such as

#!/bin/sh
less -S "$1"

After each plugin call nnn gets new child zombie, which will remain till death of the main nnn process.
exmpl
This also happens with imgview with NNN_PLUG='i:imgview'.

Thus question: Is that intented?

I hope i'm not being too stupid, but i didn't manage to find an answer or a similar question myself.

@KlzXS
Copy link
Collaborator

KlzXS commented May 12, 2021

Thus question: Is that intented?
No. Good catch.

#1000 addresses this.

@jarun
Copy link
Owner

jarun commented May 12, 2021

Haha! A good 1000th one @KlzXS! Love it that it comes from you! 👍

@jarun
Copy link
Owner

jarun commented May 12, 2021

@KlzXS I still see the zombie process with this. I tried the plugin:

#!/bin/sh
less -S "$1"

@jarun
Copy link
Owner

jarun commented May 12, 2021

Sorry! It's fixed!!!
I forgot to copy the binary to bin dir.

@KlzXS
Copy link
Collaborator

KlzXS commented May 12, 2021

You scared me with that zombie for a moment 😄

@jarun jarun mentioned this issue May 12, 2021
36 tasks
@jarun
Copy link
Owner

jarun commented May 12, 2021

LOL! 👯‍♂️

@jarun jarun added the bug label May 12, 2021
@jarun jarun changed the title Question: nnn leaves zombies while running plugins nnn leaves zombies while running plugins May 12, 2021
@GeorgMeore
Copy link
Author

Thank you for your work!

@jarun jarun mentioned this issue May 19, 2021
50 tasks
@jarun jarun mentioned this issue Jun 2, 2021
10 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants