Fix: errota Read date after time.

read RTC_TR will lock higher rancked RTC_DR causing freeze
jasonyang-ee · Jul 12, 2023 · 254cd72 · 254cd72
1 parent 22534db
commit 254cd72
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/Application/Src/RTC.cpp b/Application/Src/RTC.cpp
@@ -30,15 +30,13 @@ void CustomRTC::setDate(uint8_t day, uint8_t month, uint8_t year) {
 }
 
 std::array<uint8_t, 3> CustomRTC::getDate() {
-    if (HAL_RTC_GetDate(&m_port, &m_date, RTC_FORMAT_BIN) != HAL_OK) {
-        serialCOM.sendString("RTC Get Date Error\n");
-    }
-    return {m_date.Date, m_date.Month, m_date.Year};
+    HAL_RTC_GetTime(&m_port, &m_time, RTC_FORMAT_BIN);
+    HAL_RTC_GetDate(&m_port, &m_date, RTC_FORMAT_BIN);
+    return {m_date.Month, m_date.Date, m_date.Year};
 }
 
 std::array<uint8_t, 3> CustomRTC::getTime() {
-    if (HAL_RTC_GetTime(&m_port, &m_time, RTC_FORMAT_BIN) != HAL_OK) {
-        serialCOM.sendString("RTC Get Time Error\n");
-    }
+    HAL_RTC_GetTime(&m_port, &m_time, RTC_FORMAT_BIN);
+    HAL_RTC_GetDate(&m_port, &m_date, RTC_FORMAT_BIN);
     return {m_time.Hours, m_time.Minutes, m_time.Seconds};
 }
diff --git a/Core/Src/rtc.c b/Core/Src/rtc.c
@@ -68,7 +68,7 @@ void MX_RTC_Init(void)
   sTime.Seconds = 0x0;
   sTime.SubSeconds = 0x0;
   sTime.DayLightSaving = RTC_DAYLIGHTSAVING_ADD1H;
-  sTime.StoreOperation = RTC_STOREOPERATION_RESET;
+  sTime.StoreOperation = RTC_STOREOPERATION_SET;
   if (HAL_RTC_SetTime(&hrtc, &sTime, RTC_FORMAT_BCD) != HAL_OK)
   {
     Error_Handler();