Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback after migrating from diffx #29

Open
ghostbuster91 opened this issue Jul 10, 2023 · 2 comments
Open

Feedback after migrating from diffx #29

ghostbuster91 opened this issue Jul 10, 2023 · 2 comments

Comments

@ghostbuster91
Copy link
Collaborator

The purpose of this issue is to gather feedback from migrating projects to difflicious.

ghostbuster91/pgn-parser#2 - .assertNoDiff has to be called on the differ instance. For more complex types it is cumbersome. It would be better to write it in a way where the type can be inferred from the passed arguments.

@kostaskougios
Copy link

Yes me too. I just gave a try to the library but gave up when I realized what I have to do something like Diff[Seq[Player]].assert... . I think something like Diff.assertNoDiff(a1,a2) that infers the type would be a lot simpler.

@2m
Copy link

2m commented Jun 30, 2024

I also recently migrated from diffx and I am using this assertion method variation from the munit support:

https://github.com/2m/rallyeye/blob/391227a93eb4b608416b6745595280d2c9ac04aa/modules/backend/src/test/scala/difflicious.scala#L24-L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants