Call Native.toString() in #getFileName() & #getAlternateFileName()
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Jonathan. I merged this, though I have some doubts, that there is really a bug hidden here (from my perspective only filename could overflow). If you want to look further into this, this structure currently can only be used if w32.ascii is not set to true (this is the default). The problem is, that a TCHAR either maps to char or a wchar depending on the calling function. |
|
The structure in question wouldn't be valid for use with an ASCII function, which would require a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom logic which I removed, did not account for a missing NUL terminator. Plus, it is better to use logic already in the code base (e.g.
Native.toString()).