-
Notifications
You must be signed in to change notification settings - Fork 4
IOException
with message GOAWAY received
causes readiness check to fail fast
#155
Comments
Hi @adriansuarez , The version 0.9.6 released very recently (soon to be in maven central), just skips the health check until that is improved. Will take a look on this approach you suggests and see if helps. thx!! This issue is technically a duplicate but will keep it open to discuss your suggestion - feel free also to do a PR for you suggestion |
@csviri: Thank you for the extra context. I was very confused about why tests started failing in our repo without any code changes related to jenvtest, but it looks like it is because we are now pulling down K8s 1.29, which exposes this issue. That suggests a workaround that we could implement in our repo of pinning the version to 1.28. |
Yes, might be an option, but hopefully this will be somehow fixed soon. (Note that pinning is also possible with an env var for all tests.) |
Suppressing and retrying on I think this is due to the feature gate From the feature gates documentation:
It doesn't look like the client is having any credentials passed to it when it invokes the An easy fix is to just use HTTP/1.1 to invoke |
Is this fix included in release 0.9.7, or is this still an open issue? |
Ah, yes it si included, sorry, will close the issue. |
When invoking
KubeAPIServer.start()
, the readiness check fails with the following stacktrace:Looking into the
GOAWAY received
message, it looks like this is part of the HTTP/2 protocol, and this is just the server destroying a connection and forcing the client to establish a new one. I don't see why this should cause the readiness check to fail fast, since it could simply be an indication of the server not being ready.I'm actually not sure why any
IOException
should cause the polling loop to fail fast, since those could be an indication of the server not being ready. My proposal would be to update the polling loop from this:to this (i.e. generalize the retry condition from
ConnectException
toIOException
):Thoughts?
The text was updated successfully, but these errors were encountered: