Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 2.0.5 breaks with python 3.5.2 Linux #105

Closed
nbgooch opened this issue Sep 17, 2021 · 3 comments
Closed

[BUG] 2.0.5 breaks with python 3.5.2 Linux #105

nbgooch opened this issue Sep 17, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@nbgooch
Copy link

nbgooch commented Sep 17, 2021

Describe the bug

Charset normalizer 2.0.5 breaks with python 3.5.2 on ubuntu:trusty. We have some Jenkins job that have been running successfully for months and then on 9/14 everything broke.

To Reproduce

This is an enterprise application so I can't give you source, but we run

pip3 install hvac --user --disable-pip-version-check
python3 asoc.py

I believe you should be able to recreate with a sample app using hvac and the correct versions.

Expected behavior

python3 asoc.py
- Traceback (most recent call last):
-  File "/home/jenkins/.local/lib/python3.5/site-packages/charset_normalizer/api.py", line 5, in <module>
-   from os import PathLike
- ImportError: cannot import name 'PathLike'

Logs

+ python3 asoc.py
Traceback (most recent call last):
  File "/home/jenkins/.local/lib/python3.5/site-packages/charset_normalizer/api.py", line 5, in <module>
    from os import PathLike
ImportError: cannot import name 'PathLike'

Desktop (please complete the following information):

  • OS: [Linux]
  • Python version [3.5.2]
  • Package version [2.0.5]
@nbgooch nbgooch added bug Something isn't working help wanted Extra attention is needed labels Sep 17, 2021
@bsiper
Copy link

bsiper commented Sep 17, 2021

This is entirely due to the use of os.Pathlike, which does not exist in Python <3.6.

version 2.0.5 should probably note that it is no longer compatible with Python 3.5.

Looks like this was found a couple of days ago and fixed: #100

@Ousret
Copy link
Member

Ousret commented Sep 17, 2021

Thanks for the report, but you are a bit mistaken.
Yes I accidentally broke the compatibility with some older version but not all 3.5.x

@bsiper you are right, there is a fix available in dev-master and the PR explain everything that we should know about this.
I will publish a tag as soon as possible but I have to run some heavy testing beforehand.

Meanwhile, I suggest you to either pin charset_normalizer to 2.0.4 or upgrade your Python to latest minor 3.5.10.

@Ousret Ousret closed this as completed Sep 17, 2021
@Ousret
Copy link
Member

Ousret commented Sep 17, 2021

Now fixed and live v2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

3 participants