[NVIDIA] Relax the requirement for providing both query_seq_lengths and key_value_seq_lengths
#23415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, @sbodenstein for review. |
superbobry
requested changes
Sep 4, 2024
jax/_src/nn/functions.py
Outdated
| kv_indices = jnp.arange(0, S)[None, None, :] | ||
| q_mask = q_indices < q_seqlen[:, None, None] | ||
| kv_mask = kv_indices < kv_seqlen[:, None, None] | ||
| q_mask = jnp.array(True, dtype=jnp.bool_) |
There was a problem hiding this comment.
Can you do jnp.bool_(True) or just True here?
tests/nn_test.py
Outdated
| @@ -122,7 +122,6 @@ def testDotProductAttentionMask(self, mask_mode): | |||
|
|
|||
| is_causal = 'causal' in mask_mode | |||
| if 'padding' in mask_mode: | |||
| q_seqlen = jnp.array([T // 2, T // 4], dtype=jnp.int32) | |||
There was a problem hiding this comment.
Is this change necessary?
kaixih
force-pushed
the
key_value_seq_lengths
branch
from
12d93a4
to
2d2cbbc
Compare
|
LGTM |
superbobry
approved these changes
Sep 11, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the original
nn.dot_product_attentionrequired bothquery_seq_lengthsandkey_value_seq_lengths. With this update, users can now provide only one of these lengths, thereby relaxing the previous requirement.This is motivated by this issue.
cc. @superbobry