Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of fail open #89

Open
phillipsb22 opened this issue Jun 10, 2019 · 1 comment
Open

Addition of fail open #89

phillipsb22 opened this issue Jun 10, 2019 · 1 comment

Comments

@phillipsb22
Copy link

Good day,

We have added in an option to fail open if for any reason the limitRate function fails. For example server dies or network failure etc.

We have added this to the annotation to make the fail open dynamic.

If you could we would like your thoughts on the implementation and whether or not you would be willing to include the change in your version

here is the link to the branch

Brandon

@jaytaph
Copy link
Owner

jaytaph commented Jul 22, 2019

Hello Brandon,

Thanks for your contribution. I think this makes a lot of sense and actually, I've needed the same functionality before. Could you open a pull request so we can discuss and hopefully merge this into the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants