Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent http errors during tests #39

Open
jayvdb opened this issue Apr 5, 2020 · 1 comment
Open

Prevent http errors during tests #39

jayvdb opened this issue Apr 5, 2020 · 1 comment
Labels
Milestone

Comments

@jayvdb
Copy link
Owner

jayvdb commented Apr 5, 2020

gertty currently causes log

ERROR    https_everywhere.adapter:adapter.py:124 handle_error requests.exceptions.ConnectTimeout: HTTPSConnectionPool(host='ttygroup.org', port=443): Max retries exceeded with url: / (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x7fb191ddc580>, 'Connection to ttygroup.org timed out. (connect timeout=15)'))
ERROR    https_everywhere.adapter:adapter.py:124 handle_error requests.exceptions.ConnectTimeout: HTTPSConnectionPool(host='ttygroup.org', port=443): Max retries exceeded with url: / (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x7fb191ddc580>, 'Connection to ttygroup.org timed out. (connect timeout=15)'))

While it is useful for the library to be able to skip past those problems, the tests should highlight them so they can be raised upstream.

Another more critical one would be TooManyRedirects.

@jayvdb jayvdb added the network label Apr 5, 2020
@jayvdb jayvdb added this to the v0.2.4 milestone Apr 5, 2020
@jayvdb
Copy link
Owner Author

jayvdb commented Apr 5, 2020

b90799c was a too-many-redirects workaround - these should also be shown during tests.

@jayvdb jayvdb mentioned this issue Apr 5, 2020
@jayvdb jayvdb modified the milestones: v0.2.4, v0.2.5 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant