New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal places inconsistency #188

Open

Pacu2 opened this issue Jul 17, 2018 · 1 comment

Labels

Contributor

Pacu2 commented Jul 17, 2018

decimal_places should be equal to decimal places of the default currency, instead of being harcoded
similar is done in Saleor:

https://github.com/mirumee/saleor/blob/master/saleor/settings.py#L292
https://github.com/mirumee/saleor/blob/master/saleor/discount/models.py#L59-L61

The text was updated successfully, but these errors were encountered:

Pacu2 added the help wanted label

Pacu2 mentioned this issue

Issue on trying to insert huge total order payment saleor/saleor#2301

Closed

Pacu2 mentioned this issue

bigger decimal fields (20 digits) (hold more currencies) #153

Open

Member

WhyNotHugo commented Jan 4, 2021

It should likely be configurable.

However, making it configurable means that migrations might be non-trivial to implement properly, so this is likely not an easy issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment