-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support query_group for WLM #59
base: master
Are you sure you want to change the base?
Conversation
(It's my first Draft pull request! If this become a non-draft PR, I should review it.) |
I'll testing on my application :) |
Check on my application
Its works fine for me. |
My application using new query group :) @shimizukawa This PR is ready fore review. Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented.
@@ -1,6 +1,15 @@ | |||
CHANGES | |||
======= | |||
|
|||
1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.1
means PATCH version that should be used for minor bug fix.
1.1.0
is good for 'New Features' on semver.
def init_connection_state(self): | ||
super(DatabaseWrapper, self).init_connection_state() | ||
assignments = [] | ||
if self.query_group: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better that self.query_group
is initialized with None
on __Init__
method or class variable. (I know init_connection_state
always called after get_connection_params
)
|
||
if assignments: | ||
with self.cursor() as cursor: | ||
cursor.execute('; '.join(assignments)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using LIST type for assignments
variable?
It seems it only have single string object in this method.
@shimizukawa Thank you for your review. I'll fix it :) |
@Surgo how about this? |
@shimizukawa I'm sorry but to busy now... I'll fix within weeks.. |
OK, no problem. It's just a reminder :) |
Subject: Set
query_group
for WLMFeature or Bugfix
BugfixPurpose
query_group
when create connectionDetail
SET query_group TO <specific query group by OPTIONS>
Relates