Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call make dist in the Release action. Fixes #987 #1007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jun 29, 2022

Try to fix #987 by executing make dist from within the release action on GitHub.

May not work due to gpg failures. I don't have a way of testing it.

Description

Related Issue

#987

Motivation and Context

To avoid missing wheel packages on PyPI and unify the build process regardless in which environment it happens.

How Has This Been Tested?

It hasn't been tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@atodorov
Copy link
Contributor Author

@jeking3 can you review and comment on this? Possibly test the github action?

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1007 (cb0726f) into master (6325659) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   97.65%   97.65%   -0.01%     
==========================================
  Files          23       23              
  Lines        1151     1149       -2     
  Branches      222      222              
==========================================
- Hits         1124     1122       -2     
  Misses         12       12              
  Partials       15       15              
Impacted Files Coverage Δ
simple_history/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3070deb...cb0726f. Read the comment docs.

@atodorov
Copy link
Contributor Author

atodorov commented Aug 8, 2022

ping. any news here ?

@rossmechanic
Copy link
Collaborator

I can check this out this weekend.

@rossmechanic
Copy link
Collaborator

Don't think this will work with gpg failures. I'd rather just get rid of the github action and release manually to do it right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel package for 3.1.1 not available on PyPI
2 participants