Fix failing admin tests when testing against Django's main branch #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of failing tests: https://github.com/jazzband/django-simple-history/actions/runs/4368637153/jobs/7641472149 The commit django/django@473283d added a `log_entries` key to the dict returned by `AdminSite.each_context()`, with a value of type `QuerySet`. The cause of the failing tests seems to be that `QuerySet` hasn't implemented an `__eq__()` method (see https://github.com/django/django/blob/32d4b61c313be5169137047e9fb3668da20a5d89/django/db/models/query.py#L290), and since the tests create a new `QuerySet` instance (when calling the `each_context()` method) to compare to the arguments passed to `mock_render`, the instances won't be equal, since they're not the same object.
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 23 23
Lines 1234 1234
Branches 200 200
=======================================
Hits 1200 1200
Misses 16 16
Partials 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
joshuadavidthomas
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example of failing tests.
The commit django/django@473283d added a
log_entrieskey to the dict returned byAdminSite.each_context(), with a value of typeQuerySet. The cause of the failing tests seems to be thatQuerySethasn't implemented an__eq__()method (seequery.py), and since the tests create a newQuerySetinstance (when calling theeach_context()method) to compare to the arguments passed tomock_render, the instances won't be equal, since they're not the same object.Related Issue
Motivation and Context
How Has This Been Tested?
Through GitHub Actions.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst