Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make historical records' m2m fields type-compatible with non-historical #1187

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjsir911
Copy link
Contributor

@mjsir911 mjsir911 commented Jun 9, 2023

Fixes #1186

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@mjsir911 mjsir911 force-pushed the msirabella/m2m_swappability branch 2 times, most recently from 55decce to 9896652 Compare August 18, 2023 21:33
@mjsir911 mjsir911 force-pushed the msirabella/m2m_swappability branch from 9896652 to 2169175 Compare August 18, 2023 21:36
@tim-schilling
Copy link
Contributor

Is this something you are still working on? We'll need to update the documentation and determine if this needs a deprecation path. The tests seem to indicate we may be changing an interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistencies with field access regarding m2m fields
3 participants