Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Django's dev branch to main. #807

Merged
merged 8 commits into from
Mar 10, 2021
Merged

Rename Django's dev branch to main. #807

merged 8 commits into from
Mar 10, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Mar 9, 2021

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #807 (074a0a2) into master (0de0649) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #807   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          18       18           
  Lines         992      992           
  Branches      151      151           
=======================================
  Hits          967      967           
  Misses         12       12           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de0649...074a0a2. Read the comment docs.

@@ -5,19 +5,19 @@ on: [push, pull_request]
jobs:
build:
name: build (Python ${{ matrix.python-version }}, Django ${{ matrix.django-version }})
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically to work around an issue with installing mysqlclient on Ubuntu 20.04 that I couldn't fix:

ImportError: libmysqlclient.so.20: cannot open shared object file: No such file or directory

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can look into this later.

@jezdez jezdez merged commit 9852eea into master Mar 10, 2021
@jezdez jezdez deleted the master-to-main branch March 10, 2021 12:30
tim-schilling added a commit to tim-schilling/django-simple-history that referenced this pull request Aug 24, 2021
Coercing OneToOneFields to be ForeignKeys on historical
models causes issues when the OneToOneField is a custom
subclass that includes additional arguments that do not
exist on the ForeignKey.__init__  method.

These additional arguments can be specified via excluded_field_kwargs
to allow these custom OneToOneFields be coerced into ForeignKeys
on the historical model.

Fixes jazzband#807
tim-schilling added a commit to tim-schilling/django-simple-history that referenced this pull request Aug 24, 2021
Coercing OneToOneFields to be ForeignKeys on historical
models causes issues when the OneToOneField is a custom
subclass that includes additional arguments that do not
exist on the ForeignKey.__init__  method.

These additional arguments can be specified via excluded_field_kwargs
to allow these custom OneToOneFields be coerced into ForeignKeys
on the historical model.

Fixes jazzband#807
tim-schilling added a commit to tim-schilling/django-simple-history that referenced this pull request Aug 24, 2021
Coercing OneToOneFields to be ForeignKeys on historical
models causes issues when the OneToOneField is a custom
subclass that includes additional arguments that do not
exist on the ForeignKey.__init__  method.

These additional arguments can be specified via excluded_field_kwargs
to allow these custom OneToOneFields be coerced into ForeignKeys
on the historical model.

Fixes jazzband#807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants