Fix reading README & CHANGES RST files when the system encoding is not UTF-8 #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
open
in text mode reads files in the system encoding, however in this case we know that the encoding of the files being read is UTF-8, regardless of the platform on which the package is being installed.If this is run on a platform where the default encoding is not UTF-8, the
setup.py
call fails becauseCHANGES.rst
cannot be read in ASCII mode (due to special characters in a contributor's name).