-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip-tools should be installed in the project's virtual environment #1023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 34 34
Lines 2364 2364
Branches 303 303
=======================================
Hits 2343 2343
Misses 11 11
Partials 10 10 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Generally looks good to me. One thing which bothers me, maybe the details should be explained in its own sections for pip-compile and pip-sync?
@atugushev I've moved the details into the suggested sections, how does it look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I'll approve this, but I'd like to hear an opinion from someone else since I'm not a native English speaker.
@tekumara, thanks for your first-time contribution and welcome to the pip-tools contributors 😊 Nicely done! |
Fix #1021
Changelog-friendly one-liner: Make the readme more imperative about installing into a project's virtual environment to avoid confusion
Contributor checklist
Provided the tests for the changes.