Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated link with rationale for pinning #1053

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Jan 31, 2020

Closes #668
Refs (supersedes) toanant#1

Changelog-friendly one-liner: Replace outdated link in Readme with rationale for pinning

Contributor checklist
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@m-aciek m-aciek added this to the 4.4.1 milestone Jan 31, 2020
@m-aciek m-aciek requested review from bittner and atugushev January 31, 2020 07:45
@atugushev atugushev removed this from the 4.4.1 milestone Jan 31, 2020
@atugushev atugushev added the docs Documentation related label Feb 1, 2020
@atugushev atugushev added this to the 4.4.2 milestone Feb 1, 2020
@atugushev atugushev requested a review from vphilippon February 1, 2020 04:10
@auvipy auvipy merged commit d405bf9 into master Feb 2, 2020
@auvipy auvipy deleted the readme-pinning-rationale branch February 2, 2020 01:49
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @m-aciek,

Thanks picking up the task. I wouldn't completely delete the link to the blog post of the original author and would rather keep somewhere in a different section of README (see #668 (comment)) for historical reasons.

FYI detached link is abandoned now.

@atugushev atugushev modified the milestones: 4.4.2, 4.5.0 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme links to an outdated article
3 participants