-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis CI with GitHub Actions #1229
Conversation
Thank you @hugovk! You are right on time! 🙏 uses: deadsnakes/action@v2.0.1 FYI it fixes 3.9-dev job. |
@jezdez could you please also remove the "required" status check from Travis CI? |
I've added the |
Done. I've left appveyor though. @davidovich @vphilippon @atugushev There is a large number of test envs on GitHub actions, should any be required to pass first before a merge is happening? |
BTW, GitHub Actions supports Windows as well, do we want to get rid of Appveyor as well? |
@jezdez Thanks! I think appveyor also is a candidate to remove from CI (as well as "required" status check).
I would say:
|
Okay, I'd support that. I see there are already Windows runs set-up. Can I just disable AppVeyor? Let's at least open an issue to track this if non of the other project leads agree to do that. There is a pretty old issue about the lack of access for Jazzband members as well.
Done. |
Yeah, let's disable it first. |
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 36 36
Lines 2855 2855
Branches 332 332
=======================================
Hits 2841 2841
Misses 8 8
Partials 6 6 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects: jazzband/help#206
Tests are already run on GHA, this PR removes the Travis CI config and adds a deploy workflow. This is based on the one we already got working in https://github.com/jazzband/prettytable. The release process will be the same.
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.Changelog-friendly one-liner: Replace Travis CI with GitHub Actions
Contributor checklist