Remove futures from fake_with_deps test packages
#1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
force-pushed
the
fix-test-with-latest-setuptools
branch
from
3e7f168 to
78a2262
Compare
The latest version has python_requires in `setup.py`, which fixes failing test_realistic_complex_sub_dependencies on the latest `setuptools`.
atugushev
force-pushed
the
fix-test-with-latest-setuptools
branch
from
78a2262 to
2599d90
Compare
atugushev
changed the title
atugushev
changed the title
fake_with_deps package
|
Ouch, this pypa/setuptools#2687 (comment) broke the test again... It's better to save time and energy and remove this. |
atugushev
changed the title
fake_with_deps packagefake_with_deps test packages
This was referenced Oct 10, 2021
nicoa
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
LGTM.
thx for investigating further into this @atugushev (also over there at setuptools and pythonfutures)!
|
Thank you @nicoa 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main intention is to release
setuptools<57restriction on tests. Most users probably use fresh setuptools, so should we. Also:futuresversions breaks setuptools during installation, see details: [BUG] new release (57) breaks piptools pytest pypa/setuptools#2687 (comment)Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.