Prevent loss of deep dependencies of local requirements #1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Fixes #1054
I've just:
copy_ireq_dependencies
, which we removed as part of Ensurepip-tools
unions dependencies of multiple declarations of a package with different extras #1486 for some important fixescombine_install_requirements
from Fixing issue with losing data about local files #1385@richafrank Please have a look, as I don't know what any negative consequences or better alternatives might be.
That said, all existing tests continue to pass, and the behavior regarding those bugs is looking good.
TODO:
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.