-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show progressbar on generation hashes in verbose mode #743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 98.06% 98.41% +0.35%
==========================================
Files 34 34
Lines 1962 2019 +57
Branches 256 258 +2
==========================================
+ Hits 1924 1987 +63
+ Misses 26 21 -5
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
3001b7e
to
e23e617
Compare
Does this also show the downloading progress of the files to hash or only hashing itself? |
@kaeptmblaubaer1000 including the downloading progress. |
@kaeptmblaubaer1000 |
@graingert @proinsias |
I ran it with |
@kaeptmblaubaer1000
and paste here the output? |
|
@kaeptmblaubaer1000 it seems you didn't install a forked pip-tools. Try this one:
and paste here the output. |
I can't see any difference, probably because I already used pull/743/merge before. |
@kaeptmblaubaer1000 please provide a version by: |
|
@kaeptmblaubaer1000
where So, let's do it again in virtualenv: virtualenv .venv
source .venv/bin/activate
pip install -U git+https://github.com/atugushev/pip-tools.git@progressbar-generate-hashes#egg=pip-tools
pip-compile --version
echo numpy > requirements.in
pip-compile -v --generate-hashes |
Nope. It was already in a virtualenv, and it was activated. I guess it didn't change the PATH correctly... FYI, I'm using zsh. |
Ok, now activated again:
Looks like it does work. |
@kaeptmblaubaer1000 looks good now, but it has been generated so quick :) Could you try some heavy weight packages:
|
I already have my big set of requirements... something is wrong with it though, it now shows that it generates the hashes of numpy, and it now took more than 30 seconds even though it already has downloaded it. And it gave no progress bar for a minute and now prints it'd take 1:23:29... |
@kaeptmblaubaer1000
Could you share it? I'll try to run locally. |
@atugushev – this looks great! Thanks for doing this work. |
e23e617
to
ede863b
Compare
@blueyed @kaeptmblaubaer1000 @proinsias Guys! I've added more details on hashes generation process and made a progress-bar(s) smooth. Could you please review it again? 🙏 |
Shows a progressbar on a slow hashes generation. Uses a bar provided by
click
package.Example:
See stdout
Progressbar is shown for the packages which hashes generate operation took a time more that 0.5 secs (default click's behavior).
Context manager
nullcontext
added for conditional with statements.Refs #521.
Changelog-friendly one-liner: Show progressbar on generation hashes in verbose mode
Contributor checklist