Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /etc/mysql/mariadb.conf.d/ and /etc/mysql/conf.d/ #211

Open
williamdes opened this issue Feb 13, 2023 · 7 comments
Open

Support /etc/mysql/mariadb.conf.d/ and /etc/mysql/conf.d/ #211

williamdes opened this issue Feb 13, 2023 · 7 comments
Labels
area: startup This is related to how mariadb starts up type: feature Request to add new functionality

Comments

@williamdes
Copy link
Contributor

williamdes commented Feb 13, 2023

You also could load them like /etc/my.cnf.d/ is loaded

See: https://hub.docker.com/_/mariadb
See: https://www.linuxtricks.fr/wiki/print.php?id=559

@williamdes williamdes changed the title Support /etc/mysql/mariadb.conf.d/ and /etc/mysql/conf.d Support /etc/mysql/mariadb.conf.d/ and /etc/mysql/conf.d/ Feb 13, 2023
@jbergstroem jbergstroem added type: feature Request to add new functionality area: startup This is related to how mariadb starts up labels Feb 13, 2023
@jbergstroem
Copy link
Owner

From the upstream (mariadb) docker readme:

Custom configuration files should end in .cnf and be mounted at the directory /etc/mysql/conf.d. These files should contain the minimal changes from the MariaDB workload required for your application/environment. A MariaDB configuration file will have a [mariadb] group followed by variable = value settings per Setting Server System Variables or option-prefix-variable.

I can see that other linux distribution supports other folder names, but does it really make sense to go wider than upstream default? Does other containers do this?

@williamdes
Copy link
Contributor Author

I think it should have as much support as the MariaDB container. I did not check that it supports it, but most probably it does

@jbergstroem
Copy link
Owner

Mariadb seems to put its configs in /etc/mysql/mariadb.conf.d/ and you are expected to mount yours in /etc/mysql/conf.d/.

What are you looking for more specifically here? Layer your configs on top of defaults?

@williamdes
Copy link
Contributor Author

Mariadb seems to put its configs in /etc/mysql/mariadb.conf.d/ and you are expected to mount yours in /etc/mysql/conf.d/.

What are you looking for more specifically here? Layer your configs on top of defaults?

I expected both, but really I an not sure how they handle it
I just reported both directories because they are mysql or MariaDB images 😄

not really sure what you should really consider

@jbergstroem
Copy link
Owner

jbergstroem commented Feb 13, 2023

I expected both, but really I an not sure how they handle it

If you were to mount into the folder they use while starting up, I'm thinking it would fail. They write configs there during startup.

As for conf.d - will definitely look at supporting that.

@williamdes
Copy link
Contributor Author

williamdes commented Feb 13, 2023

If you were to mount into the folder they use while starting up, I'm thinking it would fail. They write configs there during startup.

but you can mount only a file into it 😄
that's maybe why I did this in my configs, now that you explained that

@jbergstroem
Copy link
Owner

@williamdes said:
but you can mount only a file into it 😄

You can mount a folder with many configs. I will implement this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: startup This is related to how mariadb starts up type: feature Request to add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants