Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POS tagging #36

Closed
jbesomi opened this issue Jul 8, 2020 · 3 comments
Closed

Add POS tagging #36

jbesomi opened this issue Jul 8, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jbesomi
Copy link
Owner

jbesomi commented Jul 8, 2020

Under the nlp module, add part-of-speech tagging hero.pos. Again here the solution would be to use spaCy. This should not be particularly complex as the code would resemble named_entities or noun_chunks.

Food for thoughts: having separate functions allows for simple code, but it makes the pipeline quite inefficient as every time an NLP function is called spaCy has to go through all the corpus again. Other ideas and solutions are also welcomed.

Will be implemented only after #65 is solved.

Linked PR: #57

How to contribute: CONTRIBUTE.md

@jbesomi jbesomi added enhancement New feature or request good first issue Good for newcomers labels Jul 8, 2020
@jbesomi jbesomi linked a pull request Jul 15, 2020 that will close this issue
@ghost
Copy link

ghost commented Jul 18, 2020

Hi, is this issue open for new contributions or it is already being resolved?

@jbesomi
Copy link
Owner Author

jbesomi commented Jul 18, 2020

Hi @Rickecr and welcome to Texthero!

Some days ago @samirghouri started working on this issue (see PR #57) but he left the work unfinished.

As we haven't heard from him since 8 days, I would say you can take over this issue.

I encourage you to first read CONTRIBUTING.md and PURPOSE.md as well as the review comments in #57.

You can either work on a new PR or edit the one of @samirghouri, probably it will be easier for you to start a new one (less merge conflicts and you will understand better the code).

Thank you for your help, for any question or remarks I'm available! 👍
regards,

@jbesomi jbesomi removed the good first issue Good for newcomers label Aug 13, 2020
@henrifroese
Copy link
Collaborator

Implemented and merged in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants