COFF header is changed

[nxtn]

Steps to reproduce

using System.Diagnostics;
using System.IO;
using System.Reflection.PortableExecutable;
using Mono.Cecil;

public class Program
{
    public static void Main()
    {
        const string Path = "executable.dll";

        using (var reader = new PEReader(new FileStream(Path, FileMode.Open)))
        {
            Debug.Assert(reader.PEHeaders.CoffHeader.Characteristics ==
                (Characteristics.ExecutableImage | Characteristics.LargeAddressAware));
        }

        using (var module = ModuleDefinition.ReadModule(Path, new ReaderParameters { ReadWrite = true }))
        {
            module.Write();
        }

        using (var reader = new PEReader(new FileStream(Path, FileMode.Open)))
        {
            Debug.Assert(reader.PEHeaders.CoffHeader.Characteristics ==
                (Characteristics.ExecutableImage | Characteristics.Bit32Machine));
        }
    }
}

[jbevain]

Thanks for reporting this.

Cecil is recomputing the headers, it might produce a difference after round tripping.

The issue is that we're losing the LargeAddressAware flag here?

[nxtn]

The issue is that we're losing the LargeAddressAware flag here?

Agree.

[shelllee]

two year？

[jbevain]

@shelllee I think you meant two years?