-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against circular type forwarders #806
Open
KirillOsenkov
wants to merge
4
commits into
jbevain:master
Choose a base branch
from
KirillOsenkov:dev/kirillo/reentrancy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Protect against circular type forwarders #806
KirillOsenkov
wants to merge
4
commits into
jbevain:master
from
KirillOsenkov:dev/kirillo/reentrancy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have two assemblies with type forwarders that point to each other, we enter an infinite loop and a stack overflow. This breaks the cycle by detecting reentrancy. Fixes jbevain#706
KirillOsenkov
force-pushed
the
dev/kirillo/reentrancy
branch
from
October 15, 2023 22:40
655d831
to
5ad5672
Compare
@jbevain I even added a test! |
@jbevain What can community contributors do to get this PR merged and released? This resolves a bug that my team encountered. |
This was referenced Nov 6, 2024
FYI @jbevain adding the boolean field is free because of alignment padding: |
Unfortunately it's not free for 32-bit (the size goes from 32 to 36 bytes. But there are not many exported types per assembly, so it's honestly negligible.
|
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have two assemblies with type forwarders that point to each other, we enter an infinite loop and a stack overflow.
This breaks the cycle by detecting reentrancy.
Fixes #706