Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.hc_get_fonts doesn't handle fonts names with multiple spaces #107

Closed
sz-cgt opened this issue May 20, 2016 · 1 comment
Closed

.hc_get_fonts doesn't handle fonts names with multiple spaces #107

sz-cgt opened this issue May 20, 2016 · 1 comment
Labels
Milestone

Comments

@sz-cgt
Copy link

sz-cgt commented May 20, 2016

Specifying a font like Franklin Gothic Book in a chart causes the chart to not generate.

The issue is in .hc_get_fonts at line 133 of theme.R. Instead of

str_replace("\\s+", "+") %>% 

it should be

str_replace_all("\\s+", "+") %>%

otherwise only the first space in the font name is converted to a +

@jbkunst
Copy link
Owner

jbkunst commented May 22, 2016

Thanks so much for found these bugs!

@jbkunst jbkunst added the bug label May 22, 2016
@jbkunst jbkunst added this to the v0.4.0 milestone May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants