Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to load search results for Chinese query words #399

Open
weijianwen opened this issue Nov 16, 2024 · 2 comments · May be fixed by #402
Open

Failed to load search results for Chinese query words #399

weijianwen opened this issue Nov 16, 2024 · 2 comments · May be fixed by #402

Comments

@weijianwen
Copy link

I set up a demo project https://github.com/weijianwen/hello_sphinx to demonstrate sphinx-immaterial's issues on loading search results for key words beginning with Chinese characters. Not sure if this persists for other language characters that use Unicode. By comparison, two other themes sphinx_rtd_theme and sphinx_material work as expected to display search results on the same contents.

sphinx_rtd_theme displays the search results.
截屏2024-11-16 17 28 08

sphinx_material displays the search results.
截屏2024-11-16 17 29 12

sphinx-immaterial does NOT find any matched result
截屏2024-11-16 17 30 12
@weijianwen weijianwen changed the title Failed to load search results beginning for Chinese key words Failed to load search results for Chinese query words Nov 16, 2024
@Bizordec
Copy link
Contributor

@2bndy5 maybe i should reopen #347? It would fix this issue until #338 is merged

@2bndy5
Copy link
Collaborator

2bndy5 commented Nov 19, 2024

@2bndy5 maybe i should reopen #347? It would fix this issue until #338 is merged

Sure.

Sorry I have not had a lot of time to devote to this project recently. The upstream's search implementation is the only thing blocking #338 because any API's docs would not get ranked properly.

@Bizordec Bizordec linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix search term match and highlight for Unicode chars Bizordec/sphinx-immaterial
3 participants
@weijianwen @2bndy5 @Bizordec