From 921e2fa2b7c2932b745f160ca33d48d921b45684 Mon Sep 17 00:00:00 2001
From: Jordan Borean <jborean93@gmail.com>
Date: Fri, 29 Mar 2024 06:38:49 +1000
Subject: [PATCH] Handle unknown DNS lookup failure (#80)

Handles any exception when failing to lookup the SRV record for the
default realm. The error will still be shown when the value is used but
now the module will still import.
---
 CHANGELOG.md                             | 4 ++++
 module/PSOpenAD.psd1                     | 2 +-
 src/PSOpenAD.Module/OnImportAndRemove.cs | 6 +++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e1ad915..2142044 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog for PSOpenAD
 
+## v0.5.1 - TBD
+
++ Ensure a failure in a DNS lookup does not stop the module from importing but only errors when the value is used.
+
 ## v0.5.0 - 2024-03-21
 
 + Added the following cmdlets:
diff --git a/module/PSOpenAD.psd1 b/module/PSOpenAD.psd1
index 4e4e02f..f1c3db0 100644
--- a/module/PSOpenAD.psd1
+++ b/module/PSOpenAD.psd1
@@ -14,7 +14,7 @@
     RootModule             = 'PSOpenAD.psm1'
 
     # Version number of this module.
-    ModuleVersion          = '0.5.0'
+    ModuleVersion          = '0.5.1'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()
diff --git a/src/PSOpenAD.Module/OnImportAndRemove.cs b/src/PSOpenAD.Module/OnImportAndRemove.cs
index 4c2ecf9..bfc5292 100644
--- a/src/PSOpenAD.Module/OnImportAndRemove.cs
+++ b/src/PSOpenAD.Module/OnImportAndRemove.cs
@@ -217,7 +217,11 @@ public void OnImport()
                         }
                         catch (DnsResponseException e)
                         {
-                            GlobalState.DefaultDCError = $"Error looking up SRV records for _ldap._tcp.{baseDomain}: {e.Message}";
+                            GlobalState.DefaultDCError = $"DNS Error looking up SRV records for _ldap._tcp.{baseDomain}: {e.Message}";
+                        }
+                        catch (Exception e)
+                        {
+                            GlobalState.DefaultDCError = $"Unknown error looking up SRV records for _ldap._tcp.{baseDomain}: {e.GetType().Name} - {e.Message}";
                         }
                     }
                 }