LOGMGR-139 Add maxAge to periodic-rotating-file-handlers

[y-tabata]

JIRA: https://issues.redhat.com/browse/LOGMGR-139

Since #282 seems to not be proceeded, I implemented a simpler one.

Spec

• Provide maxAge to PeriodicRotatingFileHandler (also to PeriodicSizeRotatingFileHandler).
• PeriodicRotatingFileHandler keeps logs maxAge days.
• Old logs are deleted based on its suffix.

@jamezp I would be happy if you give any kind of comment on this.

[y-tabata]

@jamezp could you review this?

[jamezp]

This would only work in certain situations. If the suffix is ever changed, it may no longer work. If it's not rotated daily this will also not really work.

The problem is this is a tough issue to tackle correctly in the handler itself. Using a cron job or something similar is really a better safer way to do this. Having the handler make assumptions on the files it should delete based on a date can be dangerous IMO.

[jamezp]

No tabs please :)

[y-tabata]

Fixed.

[y-tabata]

@jamezp

This would only work in certain situations. If the suffix is ever changed, it may no longer work. If it's not rotated daily this will also not really work.

I know. However, if we don't have some assumptions such as using the suffix, I think there is a performance issue.
For example, if we delete logs in the specified directory according to the last modified date, we need to survey all files in the directory.

Do you mean there is more possibility to be merged than this if we introduce something like FilePurger you referred to in [1]?

[1] #282 (comment)