Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jboss-logging-annotations as as core dependency #360

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Add jboss-logging-annotations as as core dependency #360

merged 1 commit into from
Dec 21, 2018

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 20, 2018

We had quite a lot of warnings when building transactions/runtime
and bean-validation/runtime.

Typically this:

[WARNING] /data/home/gsmet/git/shamrock/transactions/runtime/src/main/java/org/jboss/shamrock/transactions/runtime/interceptor/TransactionalInterceptorBase.java: unknown enum constant org.jboss.logging.annotations.Message.Format.MESSAGE_FORMAT
  reason: class file for org.jboss.logging.annotations.Message$Format not found

@gsmet gsmet added this to the 0.3.0 milestone Dec 20, 2018
We had quite a lot of warnings when building transactions/runtime
and bean-validation/runtime.
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the workaround I recommended, until we can change the loading model.

@gsmet
Copy link
Member Author

gsmet commented Dec 21, 2018

OK, let's merge then, thanks.

@gsmet gsmet merged commit d52b4cd into quarkusio:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants