Suppress warnings for internal proprietary API - Signal and SignalHandler #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rsvoboda , Can't get excited about adding a compilation parameter which will be useless as soon as GraalVM moves its target to JDK 11. I would vote for just adding the |
|
Thank you for the feedback, I will add |
rsvoboda
force-pushed
the
SuppressWarningsApplicationClass
branch
from
6acc627
to
c88f333
Compare
rsvoboda
force-pushed
the
SuppressWarningsApplicationClass
branch
from
c88f333
to
d43e8f7
Compare
|
@gsmet PR was updated and all checks passed |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress warnings for internal proprietary API - Signal and SignalHandler warnings
Discussed in #398
Solution based on https://stackoverflow.com/questions/9613857/cannot-stop-ant-from-generating-compiler-sun-proprietary-api-warnings/34966719#34966719 and https://stackoverflow.com/questions/13855700/suppress-javac-warning-is-internal-proprietary-api-and-may-be-removed-in-a-f/42406330#42406330 threads
Simple
@SuppressWarningsis not working as warning about proprietary API is tricky beast.For Java 6 there was no way to suppress them - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6476630
For Java 7 and 8 the way is via
-XDenableSunApiLintControl.For Java 9+
-XDenableSunApiLintControlway doesn't work and I wasn't able to find any solution for Java 9+.So this is just partial fix just for Java 8, once the base moves to Java 11 warnings will be back.