Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade smallrye-fault-tolerance to 1.1.0 #439

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Upgrade smallrye-fault-tolerance to 1.1.0 #439

merged 1 commit into from
Jan 7, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 7, 2019

@mkouba mkouba added this to the 0.5.0 milestone Jan 7, 2019
@mkouba mkouba requested a review from rsvoboda January 7, 2019 09:42
rsvoboda
rsvoboda approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the fix, have just one question.

shamrock-metrics-deployment dependency was introduced because MetricsCollectorFactory was added in FaultToleranceAnnotationProcessor?

@mkouba
Copy link
Contributor Author

mkouba commented Jan 7, 2019

@rsvoboda Yes, MP FT 1.1 (which is implemented by smallrye-fault-tolerance 1.1.0) depends on MP Metrics.

@mkouba mkouba merged commit 5c98517 into quarkusio:master Jan 7, 2019
maxandersen added a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@maxandersen
Merge pull request quarkusio#439 from maxandersen/betterinit2
bff3bb8 
fix: have random edit examples for jbang init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

smallrye-fault-tolerance 1.0.4 changes public interface, protean-shamrock fails to build
3 participants
@mkouba @cescoffier @rsvoboda