-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate smallrye-reactive-messaging #476
Integrate smallrye-reactive-messaging #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but should change copyright on files to 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Same comment as Ken. We are in 2019 already!
// We need to collect all business methods annotated with @Incoming/@Outgoing first | ||
for (BeanInfo bean : validationContext.get(Key.BEANS)) { | ||
if (bean.isClassBean()) { | ||
// TODO: add support for inherited business methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure SmallRye Reactive Messaging support that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either but I think it's better to add a note so that we don't forget ;-)
I've updated the copyright years and merged. |
Thanks Clement :-) |
No description provided.