Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate smallrye-reactive-messaging #476

Merged
merged 1 commit into from
Jan 12, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 11, 2019

No description provided.

Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should change copyright on files to 2019

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Same comment as Ken. We are in 2019 already!

// We need to collect all business methods annotated with @Incoming/@Outgoing first
for (BeanInfo bean : validationContext.get(Key.BEANS)) {
if (bean.isClassBean()) {
// TODO: add support for inherited business methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure SmallRye Reactive Messaging support that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either but I think it's better to add a note so that we don't forget ;-)

@cescoffier cescoffier merged commit 99ffefe into quarkusio:master Jan 12, 2019
@cescoffier
Copy link
Member

I've updated the copyright years and merged.

@cescoffier cescoffier deleted the smallrye-reactive-messaging branch January 12, 2019 13:52
@cescoffier cescoffier added this to the 0.6.0 milestone Jan 12, 2019
@mkouba
Copy link
Contributor Author

mkouba commented Jan 12, 2019

Thanks Clement :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants