Remove the Application class from the documentation and from the generated projects #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should mention this "functionality" somewhere... maybe just a note in getting started guide? |
|
@mkouba the getting started guide have been updated to remove the reference to the Application class. Would you prefer having an admonition telling that you can still use one? |
|
Yes, something like that. But I'm not quite sure whether it would be useful. Maybe just a note that you don't need app class in shamrock compared to vanilla JAX-RS? |
|
Agreed, let me add that. |
|
@mkouba I've added a note to the getting started guide. |
|
@cescoffier Thanks! |
cescoffier
deleted the
features/update-guide-to-remote-application-class
branch
maxandersen
added a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
* fix: fail early if using --native with .jsh Fixes quarkusio#510 * fix: jbang --interactive test.jsh no longer fails on empty on file. Fixes quarkusio#465 * fix: --native x.jsh prints warning instead of hard error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the removal of the Application class, this PR removes the reference to the Application class in the guides and from the project generated with the Maven plugin.