Include subclasses/implementations in serialization declaration for JAX-RS #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason methods with parameters could contribute to serialization.
It was probably added for serialization purposes but we now declare all the return types/parameters automatically.
We were not very consistent and were using classes or strings. Let's use the class when possible, it's less fragile.
|
@stuartwdouglas The tests finally passed with the latest rebase. Hopefully we will get rid of this CI issue soon. Could you take a look at this one? It would be nice to have it in 0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.
Also trimmed down a bit what is considered by
ReflectiveHierarchyStepas discussed with Stuart.And a couple of other cleanups in JAX-RS processor.
Best reviewed commit per commit.