Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail explicitly if no persistence.xml is present and no dialect can be guessed from the driver #537

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fail explicitly if no persistence.xml is present and no dialect can be guessed from the driver #537

merged 1 commit into from
Jan 16, 2019

Conversation

emmanuelbernard
Copy link
Member

See #536

@emmanuelbernard
Issue 536 Fail explicitly if no dialect can be guessed from the driver
cc0cab8 
Fail explicitly if no `persistence.xml` is present and no dialect can be
guessed from the driver
gsmet
gsmet approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI.

@stuartwdouglas stuartwdouglas merged commit e2e104a into quarkusio:master Jan 16, 2019
@stuartwdouglas stuartwdouglas added this to the 0.7.0 milestone Jan 16, 2019
@gwenneg gwenneg mentioned this pull request Aug 20, 2019
Closed
@famod famod mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuelbernard @gsmet @stuartwdouglas