Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBTM-3883 revert #2307

Merged
merged 3 commits into from
Oct 1, 2024
Merged

JBTM-3883 revert #2307

merged 3 commits into from
Oct 1, 2024

Conversation

mmusgrov
Copy link
Member

@mmusgrov mmusgrov commented Oct 1, 2024

https://issues.redhat.com/browse/JBTM-3883

This commit is reverting JBTM-3883 because it suffers from the same problems that the initial fix for quarkusio/quarkus#40256 did. For now it is the users responsibility to set the node identifier to the correct length as has been the case for most of the lifetime of ArjunaCore.

CORE !AS_TESTS !RTS !JACOCO !XTS !QA_JTA !QA_JTS_OPENJDKORB !PERFORMANCE !LRA !DB_TESTS !mysql !db2 !postgres !oracle

@jbosstm-bot
Copy link

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/535/

@jbosstm-bot
Copy link

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/535/

@jbosstm-bot
Copy link

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/535/

@jbosstm-bot
Copy link

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/536/

@jbosstm-bot
Copy link

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/536/

@jbosstm-bot
Copy link

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/535/

@jbosstm-bot
Copy link

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/536/

@jbosstm-bot
Copy link

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/536/

marcosgopen
marcosgopen approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@marcosgopen marcosgopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mike

@marcosgopen
Copy link
Member

marcosgopen commented Oct 1, 2024 •
edited
Loading

Could I ask @mmusgrov you to update the issue https://issues.redhat.com/browse/JBTM-3883 so that it is clear that we won't do it?
Could I also ask you @mmusgrov to give an update to the Quarkus PR? In fact the comment (quarkusio/quarkus#40613 (comment)) is misleading at this point. Thanks

@mmusgrov mmusgrov merged commit 751867c into jbosstm:main Oct 1, 2024
@graben graben mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosgopen marcosgopen marcosgopen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmusgrov @jbosstm-bot @marcosgopen