Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the Figure constructor instead of plt.figure #159

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

use the Figure constructor instead of plt.figure #159

wants to merge 5 commits into from

Commits on Mar 4, 2024

  1. use the Figure constructor instead of plt.figure 

    `plt.figure` retains a copy all figure objects it created, which means
that the maximum memory requirement rises with the number of figures.
    @keewis
    keewis committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    34d2a6f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. check the returned figure instead of trying to look it up using `plt.… 

    …gcf`
    @keewis
    keewis committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7d4a693 View commit details
    Browse the repository at this point in the history

  2. rename test_dataarray to create_test_dataarray 

    Otherwise `pytest` will try to execute it and complain about `return`
instead of `assert`
    @keewis
    keewis committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e4f53cc View commit details
    Browse the repository at this point in the history

  3. return just the figure

    @keewis
    keewis committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d057b76 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d95e975 View commit details
    Browse the repository at this point in the history