-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit config #90
Conversation
from xgcm but quoting the versions
based on xgcm but adding line-length for black to match current xmovie flake8 setting
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 78.65% 78.52% -0.14%
==========================================
Files 3 3
Lines 328 326 -2
Branches 61 61
==========================================
- Hits 258 256 -2
Misses 46 46
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hey @zmoon for this to work in the 'old way' you would have had to add a github workflow file, but I have started switching repos over to the pre-commit service. This is convenient since it does make linting corrections automatically! |
I just activated the service just in case. We should also add
to the README (I just tried to make a PR on your PR, but it didnt work for some reason). |
I also think we can put this PR in front of #73, which might need some more iterations. |
Great, pre-commit ci is very nice. We should still do a
You should be able to checkout my PR and commit. I can do it though. |
I'm going to start resolving the failed checks here. |
from black, isort, etc.
Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Based on xgcm's config but adding pyupgrade and facilitating the current longer line-length setting.