Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is the custom MethodLogger.instanceOf better than Class.isAssignableFrom? #251

Open
mamuf opened this issue Oct 20, 2017 · 2 comments
Open

Comments

@mamuf
Copy link

mamuf commented Oct 20, 2017

Hi, we use this library in our company's projects and I am just wondering why you do not use the Class.isAssignableFrom method instead? What are the reasons for this custom code? Thanks!

I have dug through the git blame and related issues but didn't find any hints.

The code:

private static boolean instanceOf(final Class<?> child,

@0crat
Copy link

0crat commented Oct 20, 2017

@yegor256 please, pay attention to this issue

@yegor256
Copy link
Member

@mamuf no idea :) Try to refactor and run the build. If nothing breaks, submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants