Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code mismatch between download/demo #3

Open
EleventyOne opened this issue Nov 17, 2013 · 1 comment
Open

Code mismatch between download/demo #3

EleventyOne opened this issue Nov 17, 2013 · 1 comment

Comments

@EleventyOne
Copy link

The code available here: http://jchavannes.com/include/scripts/3p/jquery.timer.js

Is different than the code available here: http://jchavannes.com/download/jquery-timer-demo.zip

I had been using them interchangeably until I found a bug that only showed up when I used the hosted version of the code. The bug doesn't show up on the downloaded version.

In brief, the bug was that I couldn't get a timer to restart itself by calling .play() after calling .stop() - in a very convoluted scenario. Using the downloaded version solved the problem.

@EleventyOne
Copy link
Author

Right, so after trying to chase down this bug for a while, it seems that it goes away when I rename the this.active to this.ANYTHINGELSE (it was magically getting set to 0 after .play() was called and before .go() was executed).

Of course, I see now that this is the only change made to the source code that's available for download. So, yeah. Good times! :)

Nevertheless, it might be worthwhile updating the hosted source code, in case someone else should run into the same kinda trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant