Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove all non-delimiter symbols from _lisp_quoted_specials #41

Open
lenianiva opened this issue May 29, 2023 · 4 comments

Comments

@lenianiva
Copy link

Can we remove the following from Symbol._lisp_quoted_specials?

('.', r'\.')
('#', r'\#')
('?', r'\?')

Removing these 3 only causes one unit test to fail:

        self.assert_parse(r'path\.join', Symbol(r'path.join'))

which imo should be this anyways:

        self.assert_parse(r'path.join', Symbol(r'path.join'))
@jd-boyd
Copy link
Owner

jd-boyd commented Jun 6, 2023

What is the case for removing them? I'm not certain why this were here in the first place, but I'm hesitant to remove them with out a strong reason in case I am missing something.

@jd-boyd
Copy link
Owner

jd-boyd commented Jun 6, 2023

I did go ahead and remove ('.', r'\.').

@lenianiva
Copy link
Author

Why should these operators be escaped at all? Is there a particular reason for them?

@jd-boyd
Copy link
Owner

jd-boyd commented Jun 7, 2023

Why should these operators be escaped at all? Is there a particular reason for them?

I'm not the original author, which is why I am hesitant to charge in. The original author no longer wanted to maintain this so I offered to take over. I'm not really sure where and how most people are using this library. The only cases I really know of is someone doing something with KiCAD and the python-epc server for emacs integration.

Digging through the history, just now, it looks like those operators are escaped especially for python-epc. I may have just broken that package in a release that was meant to fix it. I think I'm going to have to install that setup and do some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants