Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working if Path and Point are not declared globally #13

Closed
zya opened this issue Apr 28, 2014 · 1 comment
Closed

Not working if Path and Point are not declared globally #13

zya opened this issue Apr 28, 2014 · 1 comment

Comments

@zya
Copy link

zya commented Apr 28, 2014

Nothing will work when the variables below are not declared globally:
I think most importantly Path and Point

var Shape = Isomer.Shape; 
var Path = Isomer.Path;
var Color = Isomer.Color;
var Point = Isomer.Point;
//these should be on global scope for Isomer to work

Check this fiddle for live example.
This will give the error of "Point is not defined" or "Path is not defined" in some cases.
This should be optional or it should be inside the build itself.

@jdan jdan closed this as completed in 3d5269d Apr 28, 2014
@jdan
Copy link
Owner

jdan commented Apr 28, 2014

Ah thanks! The fiddle helped a lot.

Turns out I was just missing a reference to Isomer.Point in the Shape class. Patched in 3d5269d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants