Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request to make this theme an officially integrated theme #2

Open
alexanderadam opened this issue Jan 2, 2024 · 2 comments
Open

Comments

@alexanderadam
Copy link

Hello @jdcola,

thank you so much for the evernote theme.

Would you consider creating a Pull Request so that the theme is automatically usable by everybody (i.e. on mobile devices)?

It seems like the themes are TypeScript files with the style definitions integrated.

@jdcola
Copy link
Owner

jdcola commented Jan 3, 2024

@alexanderadam Thank you very much for attention.

I've been quite busy with my day-to-day office work recently, and I must admit that I'm not familiar with TypeScript since my background isn't in web development. The CSS used in this repository was something I picked up on the go...

If you're interested, would you consider contributing to the codebase? I would be happy to merge your contributions and create the pull request you mentioned.

Alternatively, I wouldn't mind if you wish to directly use the code from this repository to contribute a PR to Joplin, with a mention of its origin.

@jdcola
Copy link
Owner

jdcola commented Jan 3, 2024

@alexanderadam, I've sent you an invitation to collaborate on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants