Plumb HwSwitchDropStats through HwSwitchHandlers

Summary: As titled. This api will be needed to collect stats on mono switch architecture Reviewed By: srikrishnagopu Differential Revision: D50779572 fbshipit-source-id: cb52f36fef0a8fd164e85eee95f09e2fb4fd5bce
jdelliot · Oct 30, 2023 · 4782b3b · 4782b3b
1 parent 33dc48a
commit 4782b3b
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 0 deletions.
diff --git a/fboss/agent/HwSwitchHandler.h b/fboss/agent/HwSwitchHandler.h
@@ -97,6 +97,7 @@ class HwSwitchHandler {
 
   virtual std::map<std::string, HwSysPortStats> getSysPortStats() const = 0;
 
+  virtual HwSwitchDropStats getSwitchDropStats() const = 0;
   virtual void updateStats() = 0;
 
   virtual std::map<PortID, phy::PhyInfo> updateAllPhyInfo() = 0;

diff --git a/fboss/agent/mnpu/NonMonolithicHwSwitchHandler.cpp b/fboss/agent/mnpu/NonMonolithicHwSwitchHandler.cpp
@@ -106,6 +106,11 @@ NonMonolithicHwSwitchHandler::getSysPortStats() const {
   return {};
 }
 
+HwSwitchDropStats NonMonolithicHwSwitchHandler::getSwitchDropStats() const {
+  // TODO: implement this
+  return HwSwitchDropStats{};
+}
+
 // not used in split
 void NonMonolithicHwSwitchHandler::updateStats() {}
 

diff --git a/fboss/agent/mnpu/NonMonolithicHwSwitchHandler.h b/fboss/agent/mnpu/NonMonolithicHwSwitchHandler.h
@@ -47,6 +47,7 @@ class NonMonolithicHwSwitchHandler : public HwSwitchHandler {
   folly::F14FastMap<std::string, HwPortStats> getPortStats() const override;
 
   std::map<std::string, HwSysPortStats> getSysPortStats() const override;
+  HwSwitchDropStats getSwitchDropStats() const override;
 
   void updateStats() override;
 

diff --git a/fboss/agent/single/MonolithicHwSwitchHandler.cpp b/fboss/agent/single/MonolithicHwSwitchHandler.cpp
@@ -109,6 +109,10 @@ void MonolithicHwSwitchHandler::updateStats() {
   return hw_->updateStats();
 }
 
+HwSwitchDropStats MonolithicHwSwitchHandler::getSwitchDropStats() const {
+  return hw_->getSwitchDropStats();
+}
+
 std::map<PortID, phy::PhyInfo> MonolithicHwSwitchHandler::updateAllPhyInfo() {
   return hw_->updateAllPhyInfo();
 }

diff --git a/fboss/agent/single/MonolithicHwSwitchHandler.h b/fboss/agent/single/MonolithicHwSwitchHandler.h
@@ -50,6 +50,7 @@ class MonolithicHwSwitchHandler : public HwSwitchHandler {
   folly::F14FastMap<std::string, HwPortStats> getPortStats() const override;
 
   std::map<std::string, HwSysPortStats> getSysPortStats() const override;
+  HwSwitchDropStats getSwitchDropStats() const override;
 
   void updateStats() override;