-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing (any python version causes venv not be created #1898
Comments
Agree, this also blocks a normal |
The "no venv" warning
It doesn't block anything, it just print the warning before every shell prompt inside the directory, which I think is a really good thing.
I think this is a great point and should be addressed. mise WARN no venv found at: .../venv
mise will automatically create the venv once all requested python versions are installed.
To install the missing python tools and create the venv, please run:
mise install I don't think we should change the behaviour of the existing Only block venv creation when missing the required python version.
I don't think its a big deal that mise checks all python versions. Perhaps mise could check if the required version (first or if ts
.list_missing_versions()
.iter()
.any(|tv| tv.ba().tool_name == "python")
{
// ...
} So it would need a bit of rework. So I would say this is a nice to have enhancement, but not a bug. Next steps
|
PR for new warning: #3573 |
I think we can close this ticket now. Warning is merged and the enhancement is split into a new ticket. |
With this config, if venv does not exist and any of the Python versions specified in the config are missing, the resulting error and behavior when
cd
ing to the dir is (using 3.10 missing as the example)In combination with #1897, this seems a bit odd given that the missing version here would not even be the version with which the venv would be created.
Further, when not cd'ing to the dir but just hitting enter in it (bash integration), the error message is the same except the last
mise missing: ...
line is not output. This got me quite confused because it was the scenario where I hit the issue in, and I did not know that one of the python versions was missing.Maybe either output the "mise missing: ..." also when just hitting the enter and not cd'ing, and/or not bother with missing python versions regarding venv creation in case the venv would not be created or activated with the missing version?
mise version 2024.4.4 linux-x64 (37b44e2 2024-04-11)
The text was updated successfully, but these errors were encountered: