Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: card series filter, fix: newegg oosLabels #120

Merged
merged 12 commits into from
Sep 20, 2020
Merged

feat: card series filter, fix: newegg oosLabels #120

merged 12 commits into from
Sep 20, 2020

Conversation

admon84
Copy link
Contributor

@admon84 admon84 commented Sep 20, 2020

Description

  • Adding filterable card series (debug, 3080, and eventually 3090)
  • Added 'debug' cards for validating configuration works for "in stock" cards (don't want to miss a chance because the config was wrong - looking at you newegg config)
  • Moved oosLabels and captchaLabels to be store props instead of in each link (since they are always the same)

Testing

  • Tested 'debug' and '3080' series on all stores
  • Ran lint script

New dependencies

N/A

@admon84 admon84 marked this pull request as ready for review September 20, 2020 19:05
@admon84 admon84 requested a review from jef as a code owner September 20, 2020 19:05
@admon84
Copy link
Contributor Author

admon84 commented Sep 20, 2020

Newegg oosLabel for 'out of stock' was throwing "out of stock" message even for in-stock cards. When I noticed that I figured the "debug" series could be used for testing in-stock cards for each store and make sure it says "IN STOCK" when it should.

Doridian
Doridian previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@Doridian Doridian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment.

src/config.ts Outdated Show resolved Hide resolved
@Doridian
Copy link
Collaborator

Also please fix lint errors. Looks good otherwise.

Doridian
Doridian previously approved these changes Sep 20, 2020
View reviewed changes
jef
jef requested changes Sep 20, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, I really like what you did here!

Thank you!

src/store/includes-labels.ts Show resolved Hide resolved
@jef jef changed the title feat: card series filter, fix: newegg oosLabels feat: card series filter, fix: newegg oosLabels Sep 20, 2020
@jef jef merged commit 252459d into jef:main Sep 20, 2020
@admon84 admon84 deleted the card-series branch September 20, 2020 21:45
@jef jef mentioned this pull request Sep 21, 2020
Closed
@Ellementz
Copy link

By model would be super nice FTW3 anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

@Doridian Doridian Doridian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@admon84 @Doridian @Ellementz @jef