Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): addition of several australian sites #1651

Merged
merged 16 commits into from
Jan 17, 2021
Merged

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 11, 2021

Description

Based on the repo of OptimalMising/streetmerchant , added several australian e-tailers to the streetmerchant script.:

  • Allneeds
  • Computer Alliance
  • Dcomp
  • Evatech
  • Harris Technology
  • IGame Computer
  • Landmark Computer
  • MSY
  • PBTech
  • PCByte
  • Rosman
  • Rosman Melbourne
  • Save On It
  • Storm Computers
  • Wells Technology

Added aswell cards

  • (ASUS) Strix White OC
  • (Gigabyte) Aorus Master Type-C
  • (Colorful) battle-ax
  • (Colorful) challenger pro
  • (Colorful) igame advanced
  • (Colorful) igame ultra oc

Testing

Every single shop / item is crosstested and verified working as intended.
However: Harris Technology NEEDS! an Australia IP to work, a) via VPN (tested from my end) or b) via a proxy in australia. Outside of australia the site wont load and produces errors when loaded into streetmerchant:

[16:09:07] error :: ✖ [harristechnology] amd ryzen5600 5600x - net::ERR_CONNECTION_TIMED_OUT at https://www.ht.com.au/part/CA093-AMD-Ryzen-5-5600X-6-Core-3.7-GHz-Desktop-Processor-with-AM4-Socket-65W-Thermal-Design-Power/detail.hts

Added missing store to index.ts
Added 1 Asus Card ( STRIX OC WHITE ) to Store.ts
Added a handfull colorful cards / local variations for the AU market to Store.ts
@wofnull wofnull requested a review from jef as a code owner January 11, 2021 15:23
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for adding all of these. Just a few things.

Thanks!

src/store/model/rosman-melb.ts Outdated Show resolved Hide resolved
src/store/model/allneeds.ts Outdated Show resolved Hide resolved
src/store/model/pcbyte.ts Outdated Show resolved Hide resolved
src/store/model/rosman-melb.ts Outdated Show resolved Hide resolved
src/store/model/rosman.ts Outdated Show resolved Hide resolved
src/store/model/saveonit.ts Outdated Show resolved Hide resolved
jef
jef previously approved these changes Jan 17, 2021
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much for updating this!

@jef jef merged commit 2fa8937 into jef:main Jan 17, 2021
@wofnull wofnull deleted the australiaupdate branch January 18, 2021 06:37
@OptimalMising
Copy link

OptimalMising commented Jan 19, 2021

Have no idea how you stumbled across my repo and apologies I am not comfortable enough with git yet to submit myself but great to see the store models / links going to use :)

erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants