Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(acompc): false positives #1699

Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix(acompc): false positives #1699

merged 1 commit into from
Jan 15, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 15, 2021

Description

AcomPC had showing every card as in Stock for the last few days, after checking I found that the out Of Stock text was now under the same selector as the in Stock one, but with another text.

Updated this to the correct selector

Testing

Tested after changing out of stock is now working again as it should.

Update selector has changed
@wofnull wofnull requested a review from jef as a code owner January 15, 2021 10:24
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Makes sense. Thanks for updating 🚀

@jef jef merged commit 0a1198b into jef:main Jan 15, 2021
@wofnull wofnull deleted the acompc_patch branch January 15, 2021 19:15
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Update selector has changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants